Skip to content

feat: zano hf + bip39 - #3359

Open
MrCyjaneK wants to merge 6 commits into
devfrom
CW-1249-bip39-zano-hf
Open

feat: zano hf + bip39#3359
MrCyjaneK wants to merge 6 commits into
devfrom
CW-1249-bip39-zano-hf

Conversation

@MrCyjaneK

@MrCyjaneK MrCyjaneK commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

New zano hf and bip39 creation/restore

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@MrCyjaneK
MrCyjaneK force-pushed the CW-1249-bip39-zano-hf branch 2 times, most recently from 7e26d45 to fc3cc6e Compare July 1, 2026 10:09
@MrCyjaneK
MrCyjaneK force-pushed the CW-1249-bip39-zano-hf branch 2 times, most recently from 75006d5 to 3269099 Compare August 19, 2026 18:18
@github-actions

github-actions Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

changes in dependencies

changed git refs:
  monero
    url   https://github.com/mrcyjanek/monero_c.git -> https://github.com/mrcyjanek/monero_c.git
    ref   3bfb3856a838f2bf6b729501837bb0295dedf25d -> cd4fe366cc8d3c188c91de279f43b29c0e044b15
    path  ./impls/monero.dart -> ./impls/monero.dart

@MrCyjaneK
MrCyjaneK force-pushed the CW-1249-bip39-zano-hf branch 5 times, most recently from 4e377b7 to 162cc95 Compare August 20, 2026 13:37
@MrCyjaneK
MrCyjaneK marked this pull request as ready for review August 20, 2026 15:28
OmarHatem28
OmarHatem28 reviewed Aug 20, 2026
View reviewed changes
Comment thread cw_zano/lib/zano_wallet_api.dart
Comment on lines +145 to +148
final bip39Mnemonic = await getBip39Mnemonic();
if (bip39Mnemonic != null && bip39Mnemonic.isNotEmpty) {
return bip39Mnemonic;
}

@OmarHatem28 OmarHatem28 Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that mean bip39 doesn't have passphrase?

@MrCyjaneK MrCyjaneK Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no the code at the bottom is the legacy path

Comment thread lib/src/screens/restore/wallet_restore_page.dart Outdated
Comment thread cw_zano/lib/get_height_by_data.txt
@MrCyjaneK
MrCyjaneK force-pushed the CW-1249-bip39-zano-hf branch from dcea616 to 7f34713 Compare August 21, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MrCyjaneK @OmarHatem28