Repository navigation
fix(wal): select bounded Parquet 60 through vendored WAL3 - #82
Draft
jratliff79 wants to merge 3 commits into
Draft
jratliff79 wants to merge 3 commits into
jratliff79 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The current all-features WAL graph selects Parquet 55.2 and Thrift 0.17. This draft proposes a reproducible WAL3 → Parquet 60.1 source path with bounded decoding of malformed fragments. It is based directly on
cachix/casitamain44cfd5c5ac6d635e327393b473071861b7f7c209and contains none of #55, #69, #76, #77, or #81.Changes
vendor/README.mdrecords source revisions, packaging changes, licenses, and compressed patches for the bounded Parquet decoder and historical ZSTD window repair.Verification on this exact head
cargo test -p casita --features s3 --locked --test wal_allocation -- --test-threads=1.cargo test -p casita --all-features --locked -- --test-threads=4passed on ARM64 macOS with Rust 1.99.0, the repository's RustFS 1.0.1 binary, andprotoc: 992 library tests passed, 57 ignored, zero failed; all executed integration targets passed, including eight historical codec cases; 11 doctests passed. The Linux-only allocation target runs zero cases on macOS and is covered by the separate Linux command above.cargo-deny --all-features --locked check allpassed advisories, bans, licenses, and sources.cargo fmt --all --check,git diff --check, and frozen fixture hashes passed. A separate Git consumer pinned to this commit resolved Casita, WAL3, and Parquet from that one Git revision.Draft review boundary
This adds 377 files and about 211,000 lines, mostly copied package source. Please review whether this source ownership and update path is acceptable before treating the PR as ready. Registry advisory tools may not match path sources by registry identity, so the copied Parquet and WAL3 source and their upstream versions need explicit advisory review.
The local Linux container's 11.66 GiB limit killed the full all-features link, including with one Cargo build job; it did not reach that suite's tests. Hosted exact-head Linux/Windows/macOS checks remain necessary. S3 short-read/retry, live mixed-version rollback, concurrent peak RSS, and workload qualification are also open.
This draft does not merge or replace the contributor PRs, change release policy, relax integrity checks or thresholds, adopt a pilot pin, or start paid workloads. The paid-run pause stays in place. Fable 5.2 reviewed the dependency route independently; Codex checked the complete source selection, red/green controls, policy, and test results. AI review, hosted CI, and maintainer approval are separate.