Skip to content

SessionRepositoryImpl.java should not be included in the model dependency jar #44

Description

@pvannierop

Problem

Importing the domain/model session service dependency in the Spring Boot version of cBioPortal (work-in-progress) causes an error creating the application context. The cause is that a @MongoTemplate bean used by the SessionRepositoryImpl.java is missing.

Solution

I think that the domain package exported with the model classifier (see POM.xml) to the dependency jar incorrectly includes the SessionRepositoryImpl.java class since it contains implementation details, not domain models. I propose to move this class to a different package so that it is not exported into the dependency jar. This will remove the need to configure the Spring application context for this dependency.

A proposed change is available in #45

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions