Repository navigation
Fix externref tests - #679
Draft
jeffcharles wants to merge 1 commit into
Draft
jeffcharles wants to merge 1 commit into
jeffcharles wants to merge 1 commit into
Conversation
jeffcharles
force-pushed
the
jc.adjust-externref-tests
branch
from
October 27, 2026 20:32
4aa2212 to
cdaf594
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the issue was sometimes the GC would leave unreferenced values alone instead of collecting all of them. This approach changes it so we try using a number of values and seeing if most of them are collected. That should detect if we're not removing references well enough without failing if one isn't removed. I've re-run the test suite 3 times and there has not been a single failure.