profiler: Fill in the profiler state functions#1226
Merged
Conversation
jeffcharles
reviewed
Jun 11, 2026
jeffcharles
left a comment
jeffcharles
left a comment
Collaborator
There was a problem hiding this comment.
Code mostly looks good. Just a few nits with comments and looks like a semicolon is missing.
This patch is a follow-up to bytecodealliance#1213 It fills in the profiler state implementation, so that it can be usable from the whamm monitor. The most notable change that is not described in the original issue, is the profile result encoding format, described in the `format.rs` module.
saulecabrera
force-pushed
the
profiler-state
branch
from
30c1867 to
f95973c
Compare
jeffcharles
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up to #1213
It fills in the profiler state implementation, so that it can be usable from the whamm monitor.
The most notable change that is not described in the original issue, is the profile result encoding format, described in the
format.rsmodule.