fix(jmap): hide Contacts and Calendars when account lacks capability - #706
Open
polastre wants to merge 1 commit into
Open
fix(jmap): hide Contacts and Calendars when account lacks capability#706polastre wants to merge 1 commit into
polastre wants to merge 1 commit into
Conversation
supportsContacts and supportsCalendars checked the server-wide session capability. An account with jmap-contact-* / dav-card-* revoked still got Contacts, and one with jmap-calendar-* / dav-cal-* revoked still got Calendars, with every action failing on an authorization error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JMAP provides both session (server) and account capabilities. The account capabilities were not being check/respected.
Changes
supportsContacts and supportsCalendars checked the server-wide session capability. An account with jmap-contact-* / dav-card-* revoked still got Contacts, and one with jmap-calendar-* / dav-cal-* revoked still got Calendars, with every action failing on an authorization error.
unconditional yes, since accountCapabilities is a subset of it
and Stalwart doesn't always advertise them per-account
Related issues
Related to #563
Note: 8904d72 which addresses #563 falls back to allowing the capability if it is a shared account/group that doesn't advertise accountCapabilities. Strictly speaking, the server capability should be checked next, and not permitted if the server doesn't provide the capability.
This PR only addresses contacts/calendars and not files, but I can do a follow on to provide the same behavior for file capabilities too.
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing text -- N/AScreenshots / demo
N/A
Notes for reviewers
See the related issues section