A-1624: Wait for automatic mirror maintenance - #4146
Draft
jamiemonserrate wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Git can start automatic maintenance from
git fetchin a detached process. The agent would then release its mirror update lock and return while repacking was still in progress, allowing Hosted Agent cache generations to capture both the old and new packfiles and inflate rapidly.This keeps automatic maintenance enabled, but makes it synchronous for agent-owned mirror fetches. Both
maintenance.autoDetach=falseand the oldergc.autoDetach=falsefallback are scoped to the individual Git command, so maintenance completes under the existing update lock before the agent snapshots or returns the mirror.We deliberately do not disable automatic maintenance: the prior mirror-cache design work concluded that doing so would let long-lived mirrors grow without bound.
Context
Changes
Testing
go test ./...(with localtag.gpgSigndisabled only for the test process).go tool gofumpt -extra -w ..golangci-lint2.9.0 reports0 issues.Deployment
No configuration or migration is required. This takes effect when an agent release containing the change reaches Hosted Agents. We should watch
git.mirror.fetchduration,git.mirror.lock_wait.updatetimeouts, and mirror generation sizes because repack time will now be attributed to the fetch that triggered it.Rollback
Revert this PR to restore detached automatic maintenance. The change does not alter mirror data formats or persist configuration.
Affiliation (optional, external contributors)
Buildkite.
Disclosures / Credits
OpenAI Codex researched the code history and internal Linear, Slack, and Notion context; implemented the change and regression coverage; ran validation; and drafted this PR under Jamie's direction.