Skip to content

Performance issue in the definition of answer_module, a09_DynamicMemoryNet/a8_dynamic_memory_network.py #146

Description

@DLPerf

Hello, I found a performance issue in the definition of answer_module, a09_DynamicMemoryNet/a8_dynamic_memory_network.py,
tf.concat will created repeatedly(tensorflow 1.x) during program execution, resulting in reduced efficiency. I think it should be created before the loop in answer_module.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions