Repository navigation
Added a daily live check of EMBER that emails on failure - #86
Merged
Merged
Conversation
The unit and integration tests route EMBER's bucket and API to fixtures, so they kept passing when the archive's old bucket was deleted. A new vitest suite (npm run test:live) runs the browse pane's own code against the live bucket and API, sending each cross-origin request with the site's Origin, and checks that: the bucket lists manifests; the API lists public datasets the bucket holds; and a public video's manifest names the bucket and its blob answers a cross-origin range request. A scheduled workflow runs it daily and emails on failure, the same way CodyCBakerPhD/historia's daily tests do. Ordinary PRs skip it; PRs that change the checks run it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177WynqppVoQbTyS1CqZXhr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177WynqppVoQbTyS1CqZXhr
|
CodyCBakerPhD
marked this pull request as ready for review
October 27, 2026 15:39
Matches the same removal in bbqs-web-components' README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177WynqppVoQbTyS1CqZXhr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit and integration tests route EMBER's bucket and API to fixtures, which is why nothing caught the old bucket being deleted (#85). This adds a small live suite, run daily, that emails on failure.
npm run test:live(tests/live/ember.test.ts, its own vitest config sonpm testis unchanged) runs the browse pane's own code against the real services. Node's fetch ignores CORS, so each cross-origin request is also sent with the site'sOrigin(frompublic/CNAME) and must come back withAccess-Control-Allow-Origin. It checks that:EMBER_ARCHIVElists dataset manifests;/info/answers, andlistPublicDandisetIdsreturns datasets the bucket holds;Tests retry twice, so one network blip doesn't send an email.
.github/workflows/daily_live_checks.ymlruns it daily at 12:17 UTC and on manual dispatch. On a failed scheduled or manual run, it emails through Gmail the same wayCodyCBakerPhD/historia's daily tests do. Ordinary PRs don't run it, so an EMBER outage never reds an unrelated PR. A PR that changes the live checks does run it.Needs:
MAIL_USERNAMEandMAIL_PASSWORDas repository or organization secrets here. They aren't inherited from historia.Testing: typecheck, lint, format, the 709 unit tests and pre-commit pass. This PR's own run of the workflow passed all three live checks on the first attempt, with the email job skipped as intended for a PR.
Original prompt
do 1-2 though daily is likely sufficient; just email me as seen in https://github.com/CodyCBakerPhD/historia/blob/main/.github/workflows/daily_tests.yml
Does sentry require cookie consent?
🤖 Generated with Claude Code
https://claude.ai/code/session_0177WynqppVoQbTyS1CqZXhr