Repository navigation
Dropped the IPS_TO_SKIP secret in favor of the excluded_ips.txt file on the host - #11
Merged
Merged
Conversation
The extractor now drops the exact addresses listed in ~/.s3-log-extraction/excluded_ips.txt on the runner's host, so the regex secret and the step that required it are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LWo8Rh1Ceh8UAWkJCdHou3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LWo8Rh1Ceh8UAWkJCdHou3
CodyCBakerPhD
marked this pull request as ready for review
October 28, 2026 06:23
Keeps the new SUMMARIES_REPOSITORY_TOKEN secret from #9 and drops the IPS_TO_SKIP entry, as this pull request does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LWo8Rh1Ceh8UAWkJCdHou3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the EMBER counterpart of brain-bbqs-runners/dandi-usage-runner#12. It follows dandi/s3-log-extraction#321 (released in
s3-log-extraction1.14.1) and dandi/dandi-s3-log-extraction#108, after whichdandis3logextractionno longer readsIPS_TO_SKIP. It drops the exact addresses listed in~/.s3-log-extraction/excluded_ips.txt, the only list of excluded addresses, with one address per line and#comments.IPS_TO_SKIP: ${{ secrets.IPS_TO_SKIP }}from the extraction workflow.excluded_ips.txtas the one place to list excluded requesters, and notes that removing an address needs a fresh extraction to bring its requests back./mnt/s3-logs/ember-s3-logs. If the EMBER and DANDI runners run as the same user on Typhon, they share oneexcluded_ips.txt, so any address in it is excluded from both archives. If EMBER needs a different list, it has to run as a separate user.IPS_TO_SKIPregex into explicit addresses in that file, one per line. Patterns and CIDR networks are refused with an error. Any requester the regex matched but the list leaves out will start being extracted./mnt/s3-logs/ember-s3-logs/env, so running the DANDI install workflow did not update it. Until then the old extractor still readsIPS_TO_SKIP.IPS_TO_SKIPrepository secret.Testing
pre-commit run --all-filespasses, including the workflow schema check.Generated by Claude Code