Repository navigation
perf: replace ObjectNormalizer with json_(en/de)code (de)serializer - #49
Merged
Merged
Conversation
Owner
|
Sounds good to me, I even think we can remove |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 165 164 -1
===========================================
Files 27 27
Lines 437 465 +28
===========================================
+ Hits 437 465 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Redis transport no longer uses it at runtime; the wire-compat test keeps it as a dev dependency via a legacy_redis_serializer() helper.
Contributor
Author
I choose to keep it as dev dependency so tests prove new format is the same as |
Owner
|
Thank you @LounisBou ! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis deserializes every message on every worker before any topic filtering. Deserializations using reflection per each publish can cost a lot.
This PR change it for
json_encode/json_decode+ constructor mapping over the trivialUpdate/MessageDTOs (should be really cheaper per message).Message.idis keep (not regenerated).