chrony: render per-server time source configuration - #1030
Draft
xiaotianlyu wants to merge 1 commit into
Draft
Conversation
xiaotianlyu
force-pushed
the
chrony-per-server-config
branch
4 times, most recently
from
September 2, 2026 03:20
d30e309 to
0e656bf
Compare
Render time-servers as either the legacy URL list or a named map with per-server directives and options. Select the format with the is_array helper and render logging from the ntp.logging setting. Create and label /var/log/chrony for chronyd output. Add schnauzer render tests for both time-server formats and optional fields. Signed-off-by: Melody Lyu <tianlyu@amazon.com>
xiaotianlyu
force-pushed
the
chrony-per-server-config
branch
from
September 2, 2026 20:27
8f01b47 to
e6e941f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the chrony configuration template to support both forms of
settings.ntp.time-servers.The existing list form remains supported:
Each entry is rendered as a
poolline with the shared options.The new named form can configure each time source separately:
This is rendered as:
This PR also:
settings.ntp.loggingas chrony log categories;/var/log/chronyfor those logs;The named settings model is added by the related settings-sdk PR. bottlerocket-os/bottlerocket-settings-sdk#146
Testing done:
Unit test:
cd sources && cargo test -p schnauzer --test chrony_conf_render4 tests passed, covering:
On-box testing with the complete three-PR change:
aws-k8s-1.32x86_64 AMI;1.64.0to the test1.65.0image;/etc/chrony.confcontained the expectedserverandpoollines;chronydwas active with no restarts;measurements.log,statistics.log, andtracking.logwere written under/var/log/chronywith the expected owner andmeasure_tSELinux label;1.64.0successfully.Related PRs:
This PR depends on a settings-sdk release containing PR #146. The Bottlerocket PR depends on a core-kit release containing this change.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.