Skip to content

Update tsconfig.json - #1467

Open
ironspec07 wants to merge 3 commits into
boostercloud:mainfrom
ironspec07:patch-2
Open

Update tsconfig.json#1467
ironspec07 wants to merge 3 commits into
boostercloud:mainfrom
ironspec07:patch-2

Conversation

@ironspec07

@ironspec07 ironspec07 commented Oct 11, 2023

Copy link
Copy Markdown

Description

Added sourceMap: true to the tsconfig.json of the new project which allows users to debug from VSCode easily by pressing F5

Changes

Added "sourceMap" : true to tsconfig.json

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@what-the-diff

what-the-diff Bot commented Oct 11, 2023

Copy link
Copy Markdown

PR Summary

  • Inclusion of Source Map
    The configuration file for our TypeScript project was updated to generate source maps. This allows us to trace back any errors or bugs to the original source code, enhancing the debugging process and overall maintainability of the project.

@ghost

ghost commented Oct 11, 2023

Copy link
Copy Markdown
👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@NickSeagull NickSeagull left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be added to the project template not the Booster tsconfig 😅

@ironspec07

Copy link
Copy Markdown
Author

Sorry 😅, I am kinda new to open source contributions.

@ironspec07

Copy link
Copy Markdown
Author

Thanks for the suggestion. @NickSeagull

@NickSeagull NickSeagull left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's see if the tests pass! 👏

@NickSeagull

Copy link
Copy Markdown

/integration sha=8b29da3

@github-actions

Copy link
Copy Markdown
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed

@NickSeagull

Copy link
Copy Markdown

Hey @ironspec07 can you edit the integration test at packages/framework-integration-tests/integration/provider-unaware/cli/cli.project.integration.ts:358:15 so it checks for the existence of the sourceMap field?

It is failing in the integration tests: https://github.com/boostercloud/booster/actions/runs/6497419214/job/17646575081#step:3:720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants