This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Conversation
billychow
commented
Feb 26, 2013
- Fixed compatibility with PHP 5.2 which doesn't support late static binding
- To force DOMDocument load by UTF-8 (dirty fix)
- Remove redundant libxml error
added 2 commits
February 25, 2013 17:09
…nding yet To force DOMDocument load by UTF-8 (dirty fix)
Member
|
If you can resolve that one comment then I'll test this and pull it in. |
Author
|
I've tried, but it's not working as we expected. refer to: http://www.php.net/manual/en/domdocument.loadhtml.php |
Member
|
On second thought, we can't hard code this as UTF-8. If there's another encoding in use we don't want to import it as UTF-8. We should find the encoding from the document that we're parsing, if there isn't one it should default to ISO-8859-1 as the HTTP 1.1 spec says that's what the default should be. It looks like this is going to be a little bit bigger than the simple fix proposed above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.