Repository navigation
Add iconDark to profile links - #85
Closed
vineyardbovines wants to merge 1 commit into
Closed
vineyardbovines wants to merge 1 commit into
vineyardbovines wants to merge 1 commit into
Conversation
vineyardbovines
requested review from
devinivy,
estrattonbailey,
mozzius and
rafaeleyng
as code owners
October 23, 2026 15:04
|
Claude finished @vineyardbovines's task in 48s —— View job ReviewNo findings. Both fields are optional and additive, so existing records, views and clients aren't affected. What I checked:
|
Contributor
Lexicon lint findings
|
mozzius
approved these changes
Oct 23, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
iconDarkto profile links, for a site's icon in a dark color scheme (APP-3616).app.bsky.actor.link#main.iconDark: blob, same limits asicon.app.bsky.actor.defs#profileLinkView.iconDark: image URL, likeicon.Clients use
iconwheniconDarkis missing, so existing links and clients are unaffected. The dark icon comes from cardyb's/v1/favicon?scheme=dark(bluesky-social/tango#1843).goat lex lintreports the same existingunlimited-stringwarnings ondefs.jsonas on main, and none for these fields, so this needslex-lint-overridelike #84.