frontend: store: Divide disk write rate by linux2rest sample window - #4175
Merged
patrickelectric merged 2 commits intoAug 18, 2026
Conversation
joaoantoniocardoso
force-pushed
the
fix/disk-widget-write-rate-sample-interval
branch
2 times, most recently
from
August 18, 2026 14:54
5f875ca to
b2fe8bd
Compare
joaoantoniocardoso
marked this pull request as ready for review
August 18, 2026 14:55
This comment was marked as resolved.
This comment was marked as resolved.
joaoantoniocardoso
force-pushed
the
fix/disk-widget-write-rate-sample-interval
branch
from
August 18, 2026 15:06
b2fe8bd to
0c908f9
Compare
patrickelectric
approved these changes
Aug 18, 2026
patrickelectric
approved these changes
Aug 18, 2026
Member
|
Because 1 approve is not enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W: … MB/s) treated eachavailable_space_Bjump as happening over the 2 s frontend poll. linux2rest only refreshes that snapshot every 5 s, so a ~2.1 MB/s recording showed as ~5.0–5.1 MB/s, then stuck there because a later zero delta kept the inflated rate.linux2restProbeRateBps). Match disks bymount_point(many bind mounts sharename: /dev/root). Drop unusedDisk.last_update.Helps #4172: this PR doesn't solve it, but at least we get a correct reading from the widget
Related (not required for this PR): patrickelectric/linux2rest#38
Test plan
core/frontendwithBLUEOS_ADDRESS=http://<vehicle>/ yarn devxx/yyGB (zz%))