Skip to content

fix: prevent double-encoding of redirect_uri in login URL - #7

Merged
devops-bda merged 1 commit into
mainfrom
fix/double-encode-redirect
Apr 2, 2026
Merged

devops-bda merged 1 commit into
mainfrom
fix/double-encode-redirect

Conversation

@phanikumarps

Copy link
Copy Markdown
Contributor

Summary

  • vscode.Uri.parse() re-encodes the already-encoded URL, turning ? into %3F in the redirect_uri
  • Pass true as second arg to skip encoding
  • Fixes "page not found" on Keycloak device verification page

Test plan

  • Run ABAPer: Login — Keycloak device page loads correctly with ?user_code=XXXX

🤖 Generated with Claude Code

vscode.Uri.parse re-encodes the already-encoded URL, turning ? into %3F.
Pass true as second arg to skip encoding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@devops-bda
devops-bda merged commit 2c4f147 into main Apr 2, 2026
1 check passed
@devops-bda
devops-bda deleted the fix/double-encode-redirect branch April 2, 2026 05:36
This was referenced Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants