Skip to content

types/block.zig: evaluate or remove finishSingleRawAggregatePrep degenerate fast-path #928

Description

@zclawz

Context

Raised by @ch4r10t33r in PR #925 review.

finishSingleRawAggregatePrep in pkgs/types/src/block.zig is a degenerate-shape fast-path for 1 gossip sig + 0 children that still invokes leanMultisig once but skips child-selection loops entirely.

Action Required

  • Measure whether this path provides a meaningful performance improvement compared to the general path
  • If the improvement is negligible or unmeasurable under realistic conditions: remove the code and use the general path only (simpler, less surface area)
  • If there is a clear improvement: document it with a benchmark and keep it

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions