ci: Pass the resolved build run ID to the release trigger - #582
ci: Pass the resolved build run ID to the release trigger#582mimartin12 wants to merge 1 commit into
Conversation
The deploy-side release-helm-charts resolves the chart package by newest successful build on main, which GitHub's run listing served stale on 2026-08-10 — it returned a June 23 run, published nothing, and reported success. Pinning the run CD already resolved removes the guess. Requires the matching build_run_id input on deploy's release-helm-charts before this merges; workflow_dispatch rejects undeclared inputs.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the four-line change to Code Review DetailsNo blocking findings. |
Tracking
https://bitwarden.atlassian.net/browse/SHOT-250. Follow-up to the 2.2.0 release that published nothing on 2026-08-10.
Objective
The
releasejob triggers deploy'srelease-helm-chartswith no payload, so deploy picks the chart package itself using "newest successful self-host.yml build on main". On 2026-08-10 GitHub served that listing stale and returned a June 23 run holding self-host 2.0.1.cr uploadskipped it as already released,cr indexreported no change, and every job went green. 2.2.0 is on main but was never published.wait-for-buildalready resolves the run that packaged the bumped version, then throws the ID away. This passes it through so deploy publishes that exact artifact.Four lines: a job output, an
idon the existing step, one$GITHUB_OUTPUTwrite, and thedata:payload.Two things to know:
build_run_idinput before this merges.workflow_dispatchrejects inputs it doesn't declare, so the trigger would fail outright.