Update T-SQL Style Guidance - #839
Conversation
Establishes the rule that datetime values must be generated in application code and passed as parameters rather than using SYSUTCDATETIME()/GETUTCDATE() inline. Documents the four accepted exceptions found in the codebase: account revision date bumping, bulk operations with consistent timestamps, WHERE clause predicates, and nullable parameter fallbacks.
…ance Clarifies stored procedure naming with standard action verbs, moves parameter guidance to the basic structure section, adds a naming convention for full unabbreviated names, and notes EDD constraints on deployment scripts.
Expands user defined types guidance with OPENJSON examples for passing structured data as an alternative to new TVPs, clarifies parameter values should come from application code, and adds guidance against wrapping single statements in explicit transactions based on existing anti-patterns in the codebase.
This reverts commit 203fa00.
Deploying contributing-docs with
|
| Latest commit: |
34070c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c1cfca0.contributing-docs.pages.dev |
| Branch Preview URL: | https://sql-style-guidance.contributing-docs.pages.dev |
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This is a documentation-only change to Code Review DetailsNo findings at or above the reporting threshold. Out-of-scope note (pre-existing, not introduced by this PR): the "This is better" snippet in the Adding a column to a table section has an unbalanced parenthesis — |
withinfocus
left a comment
withinfocus
left a comment
There was a problem hiding this comment.
Appreciate the updates. Looks solid.
2 participants
📔 Objective
Update SQL style guidance for various sections.