More bitcore-cli tweaks and improvements#4177
Open
kajoseph wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves bitcore-cli wallet creation/export UX, especially for TSS wallets, and updates tests for the new flows and ANSI formatting behavior.
Changes:
- Reworks TSS creation/join completion to prompt for encrypted keyshare backups instead of showing mnemonic-only recovery.
- Updates CLI prompt wording, address-type prompting, TSS registration handling, and export/import password labels.
- Adjusts ANSI formatting helpers/tests and renames the package bin command to
bitcore-cli.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/bitcore-cli/package.json |
Renames the exposed CLI bin from wallet to bitcore-cli. |
packages/bitcore-cli/src/constants.ts |
Changes color reset sequences and marks constants readonly. |
packages/bitcore-cli/src/utils.ts |
Uses targeted ANSI style-off sequences for text formatting helpers. |
packages/bitcore-cli/src/prompts.ts |
Adds single-option address type shortcut and TSS keyshare backup prompt. |
packages/bitcore-cli/src/wallet.ts |
Uses cached reload after TSS creation and updates unlock prompt wording. |
packages/bitcore-cli/src/commands/create/index.ts |
Skips mnemonic display when TSS creation returns no mnemonic. |
packages/bitcore-cli/src/commands/create/createSingleSig.ts |
Updates wallet password prompt wording. |
packages/bitcore-cli/src/commands/create/createMultiSig.ts |
Updates wallet password prompt wording. |
packages/bitcore-cli/src/commands/create/createThresholdSig.ts |
Adds TSS exchange instructions and keyshare backup export flow. |
packages/bitcore-cli/src/commands/join/index.ts |
Skips mnemonic display for TSS join flow. |
packages/bitcore-cli/src/commands/join/joinMultiSig.ts |
Updates wallet password prompt wording. |
packages/bitcore-cli/src/commands/join/joinThresholdSig.ts |
Adds TSS keyshare backup export flow after joining. |
packages/bitcore-cli/src/commands/export.ts |
Fixes programmatic readonly: false handling and renames export password prompt. |
packages/bitcore-cli/src/commands/import.ts |
Renames import password prompt. |
packages/bitcore-cli/src/commands/register.ts |
Blocks registering existing TSS wallets as regular single-sig wallets. |
packages/bitcore-cli/src/commands/status.ts |
Updates wallet info title casing. |
packages/bitcore-cli/test/utils.test.ts |
Updates ANSI formatting expectations. |
packages/bitcore-cli/test/proposals.test.ts |
Updates proposal badge ANSI reset expectations. |
packages/bitcore-cli/test/create.test.ts |
Updates TSS create tests for keyshare backup export and assertions. |
packages/bitcore-cli/test/tssCoordinator.ts |
Changes TSS test process EOF coordination. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelAJay
reviewed
May 28, 2026
|
|
||
| if (key.isPrivKeyEncrypted() || (key as TssKey.TssKey).isKeyChainEncrypted?.()) { | ||
| const walletPassword = await getPassword('Wallet password:'); | ||
| const walletPassword = await getPassword('Unlock wallet:'); |
Contributor
There was a problem hiding this comment.
Fine as is, but "Unlock wallet with wallet password", on the same terminal screen as "File encryption password", would be even more friendly.
MichaelAJay
approved these changes
May 28, 2026
nitsujlangston
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes various bitcore-cli bugs and makes some flow improvements
Changelog
Unlock walletprompt. This is to assist user comprehension when exporting a wallet, which asks for an encryption password immediately followed by an unlock password (non read-only export).\x1b[0m(which also removes any previous text formatting)opts.readonlybeing false in exportWallet()--registerfrom working on a TSS wallet since that'll register the wallet as just a single-sig walletwallet(very generic) tobitcore-cli(more specific)Testing Notes
Add any helpful notes for reviewers to test your code here.
Checklist