Clarify partial mining reward dashboard message#1705
Conversation
|
untested ack, thisll go nice with 1703 |
|
also cc #1652 |
|
Thanks for the quick ack @0xf0xx0! This is indeed a minimal change just to fix the misleading warning for legitimate partial reward cases (especially SRI donation mode). Once this gets merged, we can continue with the more complete solution in #1678 (toggle + better coinbase handling). Let me know if you want me to test anything specific or if there's any adjustment needed before merging. |
|
@0xjc65eth Please do not open this many PRs. We do not have the capacity to review them all and are flooding the system. Pick one to keep open, which you deem highest priority and close the rest, so we can focus. |
Sorry about that. I got a bit carried away trying to help clean up and fix several things at once. I understand the team has limited review capacity and I didn't mean to flood the queue. I'll close the lower priority ones right now and keep only the one I believe is highest priority open. Which one would you prefer I keep open? Or should I choose myself based on impact? Thanks for the feedback and for maintaining the project. Happy to adjust and focus on what brings most value. Best regards, |
Thanks, it was a bit overwhelming. Pick one you think is most useful. |
|
Thanks @mutatrum, understood. I will keep this PR open as the single focused one because it is small, UI-only, already has an ack, and directly addresses the misleading partial mining reward warning in #1703 / #1652. I am closing the other PRs for now to reduce review load. Happy to revisit them later only if maintainers ask for them. Thanks again for the feedback and for maintaining the project. |
| if (info.coinbaseOutputs && info.coinbaseOutputs.length > 0) { | ||
| let percentage = this.getPayoutPercentage(info); | ||
| updateMessage(percentage > 0 && percentage < 95, 'NOT_SOLO_MINING', 'warn', `Your share of the mining reward is only ${percentage.toFixed(1)}%`); | ||
| updateMessage(percentage > 0 && percentage < 95, 'NOT_SOLO_MINING', 'info', `Mining reward is split; your decoded share is ${percentage.toFixed(1)}%`); |
There was a problem hiding this comment.
Not sure what the word decoded does here. If I can suggest:
Mining reward is split. Your share is
3 participants
Summary
Fixes the most visible part of #1703 by changing the dashboard message for decoded partial mining rewards from an alarming warning to a neutral informational message.
Before:
Your share of the mining reward is only X%After:
Mining reward is split; your decoded share is X%The existing zero-share warning is unchanged:
You don't have a share in the mining rewardWhy
For Sv2 Extended Channel setups such as the SRI pool donation mode described in #1703, a partial decoded payout can be intentional and valid. The previous wording made expected reward splitting sound suspicious even when AxeOS successfully decoded that the user has a non-zero share.
This keeps the useful visibility while avoiding an accusatory warning for legitimate split-reward configurations.
Scope
This is intentionally small and UI-only:
There is also a broader existing PR (#1678) that adds a toggle and larger coinbase-output handling. This PR is meant as a minimal alternative/foundation that can be reviewed independently.
Testing
npm ciinmain/http_server/axe-os.npm run buildsuccessfully.Build completed with the existing Angular initial bundle budget warning, but exited successfully.