fix(ios): complete photo and video copies asynchronously and truthfully - #152
Closed
OskarEichler wants to merge 1 commit into
Closed
fix(ios): complete photo and video copies asynchronously and truthfully#152OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Remove the unbounded dispatch-group wait from video copying; complete within the PhotoKit callback; reject missing/non-file assets and PhotoKit/copy errors; check image encoding and atomic-write results.
Compatibility / breaking changes
No signature changes. Failed asset copies now reject instead of hanging or reporting success. AVAsset results without a file URL are explicitly rejected; this does not add composition export support. The native module queue is no longer blocked while PhotoKit fetches a video.
Verification
Actual video method with Foundation/PhotoKit doubles covers delayed success, missing asset, non-URL asset, PhotoKit error and copy failure. A recording dispatch-wait shim avoids hanging the baseline diagnostic and confirms its blocking path; the fixed implementation has no wait and all 5 cases pass. Actual iOS Simulator SDK compilation passes. No real photo-library/iCloud/device test is claimed.
Shared verification
yarn test(ESLint + TypeScript),yarn prepare(module/declarations), andgit diff --checkpass for the combined review checkout. React Doctor reports 100/100 for the changed JS scope. Native checks are described above; no physical-device, signed-release or production verification is claimed. No checked-in test/spec files were changed. Isolated diagnostics were run outside the repository. Consumer verification at immutable combined pin eb4ee67 (RN 0.87.1): immutable install and lint, both Android Debug flavors, both iOS Simulator Debug schemes, four release-mode Metro bundles, 13 production web builds and four browser-extension builds pass. All 72 installed non-metadata files match reviewed source/rebuilt artifacts. Windows SDK/runtime remains unverified.