fix(ios): use resolved bookmark paths for file operations - #151
Open
OskarEichler wants to merge 1 commit into
Open
fix(ios): use resolved bookmark paths for file operations#151OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Use resolved bookmark URLs/paths when reading, appending, moving and unlinking; report data-read failures; close read/append handles before settling; query the documented NSURL directory resource key.
Compatibility / breaking changes
No signature changes. Operations on security-scoped bookmark strings now use their resolved file, rather than treating the bookmark as a filesystem path. Unreadable files reject instead of resolving nil. The resource-key adjustment is not claimed to fix a reproduced macOS directory failure: the old key worked in that diagnostic.
Verification
Actual Objective-C methods and pathToUrl against real Foundation bookmark data and temporary files: normal paths, bookmark reads/appends/moves/unlinks, partial reads and directory rejection. Four failing baseline bookmark operations -> zero. Actual iOS Simulator SDK compilation passes; sandboxed document-provider permissions were not exercised.
Shared verification
yarn test(ESLint + TypeScript),yarn prepare(module/declarations), andgit diff --checkpass for the combined review checkout. React Doctor reports 100/100 for the changed JS scope. Native checks are described above; no physical-device, signed-release or production verification is claimed. No checked-in test/spec files were changed. Isolated diagnostics were run outside the repository. Consumer verification at immutable combined pin eb4ee67 (RN 0.87.1): immutable install and lint, both Android Debug flavors, both iOS Simulator Debug schemes, four release-mode Metro bundles, 13 production web builds and four browser-extension builds pass. All 72 installed non-metadata files match reviewed source/rebuilt artifacts. Windows SDK/runtime remains unverified.