fix: isolate upload callbacks and always release subscriptions - #146
Closed
OskarEichler wants to merge 1 commit into
Closed
fix: isolate upload callbacks and always release subscriptions#146OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Filter current and deprecated upload callbacks by jobId; clean up on native rejection, synchronous native failure and partial listener registration; normalize file:// upload paths without mutating caller objects; retain response data for non-standard HTTP errors.
Compatibility / breaking changes
No TypeScript signature changes. Upload callbacks no longer receive other jobs. Native setup failures now reject the returned promise instead of escaping synchronously. Unknown HTTP status errors retain error.result and use an HTTP fallback message.
Verification
Actual transpiled entrypoint with event/native doubles: concurrent and deprecated callbacks, rejection, setup/registration failures, invalid files, frozen file URI options, and HTTP 500/599. Baseline cross-job calls/leaks and missing HTTP599 response reproduce; fixed cases pass.
Shared verification
yarn test(ESLint + TypeScript),yarn prepare(module/declarations), andgit diff --checkpass for the combined review checkout. React Doctor reports 100/100 for the changed JS scope. Native checks are described above; no physical-device, signed-release or production verification is claimed. No checked-in test/spec files were changed. Isolated diagnostics were run outside the repository. Consumer verification at immutable combined pin eb4ee67 (RN 0.87.1): immutable install and lint, both Android Debug flavors, both iOS Simulator Debug schemes, four release-mode Metro bundles, 13 production web builds and four browser-extension builds pass. All 72 installed non-metadata files match reviewed source/rebuilt artifacts. Windows SDK/runtime remains unverified.