Skip to content

Respect custom dates in kline downloads - #487

Open
vincenzofamoso wants to merge 1 commit into
binance:masterfrom
vincenzofamoso:fix/kline-start-date
Open

Respect custom dates in kline downloads#487
vincenzofamoso wants to merge 1 commit into
binance:masterfrom
vincenzofamoso:fix/kline-start-date

Conversation

@vincenzofamoso

Copy link
Copy Markdown

Summary

  • generate the daily kline date list from -startDate instead of always starting at PERIOD_START_DATE
  • use -endDate as the upper bound when it is provided
  • keep the existing 2020-to-today defaults when neither option is set

Fixes #398.

Verification

  • python3 -m py_compile python/*.py
  • verified get_daily_dates("2017-08-17", "2017-08-19") returns all three requested dates
  • verified a start date later than the end date produces an empty range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix PERIOD_START_DATE restricts downloads before 2020-01-01

1 participant