refactor: 알림 발행 이벤트 기반으로 전환 및 관리자 알림 쿼리 오류 수정#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
버그 수정
USER_RETURN_APPROVED알림 누락NotificationRepositoryCustomImpl의USER_TYPE리스트에USER_RETURN_APPROVED가 없어 반납 승인 알림이 저장은 되지만 사용자에게 조회되지 않던 문제 수정FCMService예외 처리 정상화sendAsync()는 non-blocking으로try-catch가 동작하지 않아 FCM 오류가 완전히 무시되던 문제 수정send()로 교체하여FirebaseMessagingException정상 처리 (비동기 처리는 이벤트 핸들러의@Async에 위임)관리자 알림 조회 쿼리 수정
member = null로 저장되는 공지식 구조인데, 기존 쿼리가member.id = memberId조건을 사용해 항상 빈 결과를 반환하던 문제 수정member IS NULL조건으로 변경리팩토링
ApplicationEventPublisher기반 알림 발행으로 전환RentalService가NotificationService를 직접 호출하던 구조를, 도메인 이벤트 발행 방식으로 전환했습니다.RentalService에서NotificationService의존 제거RentalAppliedEvent,RentalCancelledEvent,ReturnAppliedEvent,RentalStatusChangedEvent💬리뷰 요구사항(선택)