Repository navigation
Enforce required provider secrets on create and upgrade - #262
Merged
Merged
Conversation
Providers declare required_secret_env_vars, but they were only checked when mutating allowed domains/endpoints. `paude create --provider anthropic-oauth` without CLAUDE_CODE_OAUTH_TOKEN exported built a session whose proxy had no token, so the agent failed to authenticate with no hint why. The same applied to ANTHROPIC_API_KEY and OPENAI_API_KEY. Add check_required_secrets() to the provider registry, with an optional per-provider auth_hint, and call it from create (after dry-run, before any build) and upgrade (before the manifest save, teardown, or stopping a running session). start/connect are unchanged since an existing proxy keeps its bindings; the missing-proxy recreate gap is logged as PROXY-001. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upgrade now refuses to add a provider whose required secrets are missing from the host environment. The chatgpt->openai swap test adds the openai provider, so it failed in CI where OPENAI_API_KEY is unset. Provide a dummy key so the test exercises the swap itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providers declare required_secret_env_vars, but they were only checked when mutating allowed domains/endpoints.
paude create --provider anthropic-oauthwithout CLAUDE_CODE_OAUTH_TOKEN exported built a session whose proxy had no token, so the agent failed to authenticate with no hint why. The same applied to ANTHROPIC_API_KEY and OPENAI_API_KEY.Add check_required_secrets() to the provider registry, with an optional per-provider auth_hint, and call it from create (after dry-run, before any build) and upgrade (before the manifest save, teardown, or stopping a running session). start/connect are unchanged since an existing proxy keeps its bindings; the missing-proxy recreate gap is logged as PROXY-001.