Recover Safari setup tests on the first attempt - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A setup test could stay on Google until the user started another attempt. The early navigation handler waited for a native diagnostic reply before redirecting, and a missed early event had no recovery path. Remove diagnostics from the redirect’s critical path and add a page-driven recovery path for the same test.
Validation: 69 JavaScript tests passed, including modeled event loss, a stalled/throwing diagnostic bridge, startup storage delay, duplicate events, stale tokens, disabled redirects, tab navigation away, and completion timing. iOS Simulator and macOS app/extension builds passed on Xcode 16.4; packaged resources match source, and the simulator app launches.
The exact physical-phone trigger is not yet confirmed. The runbook includes cold and back-to-back Safari tests; simulator launch and modeled event-loss tests do not replace that acceptance check.