Include link_deps in Rust runfiles - #4204
Open
finn-ball wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_depsinto Rust target runfileslink_depsalongside those fromdepsWhy
link_depsparticipates in native linking, but its runfiles and dynamic libraries were omitted whenrustc_compile_actionassembled runtime files. Binaries and library targets that link native dependencies throughlink_depscould therefore be built successfully while missing required runtime artifacts.Impact
Rust binaries,
cdylibs, andstaticlibs now carry the runtime files needed by dependencies declared throughlink_deps.Validation
bazel test //test/unit/link_deps:allgit diff --check