Validate extra link-time callbacks with Starlark Args - #827
Open
dzbarsky wants to merge 2 commits into
Open
Conversation
dzbarsky
marked this pull request as ready for review
August 2, 2026 22:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate extra link-time library callbacks with
ctx.actions.args().add_all([], map_each = callback)immediately before invocation.Args.add_allperforms the same top-level-function check as_cc_internal.check_toplevel, so the C++ Java helper is no longer needed.Validation: 88 C++ common and binary analysis tests passed, including new tests for top-level and nested callbacks.