Remove ignored experimental shared-library flag lookup - #825
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
marked this pull request as ready for review
July 31, 2026 19:06
Collaborator
|
I know there's some behavioral differences between cc_binary making a shared library and a cc_shared_library (so we can't trivially migrate everything). @trybka @pzembrod do we want to encourage migration in the future? Also, are we using experimental_cc_shared_library for anything except those two attribute checks in cc_shared_library? Can we remove that check too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the cc_binary dynamic_deps conditional that queries check_experimental_cc_shared_library and discards its result. The meaningful flag-dependent check in cc_shared_library_impl remains unchanged.
Validation: 88 remote C++ binary and ThinLTO analysis tests passed.