feat: add Sepolia Solana bridge ownership transfer task (CHAIN-4636)#745
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
xenoliss
force-pushed
the
bo/chain-4636
branch
3 times, most recently
from
28f05c4 to
04752ed
Compare
roger-bai-coinbase
previously approved these changes
Jun 23, 2026
Transfer control of the six Base Sepolia Solana bridge contracts from the aliased old Coinbase L1 multisig to the aliased new Coinbase L1 multisig, via seven OptimismPortal2 L1->L2 deposits issued from the old multisig. Mechanisms (matching on-chain ownership): - transferOwnership: Bridge (OwnableRoles), TwinBeacon, CrossChainERC20Beacon - ERC1967Factory.changeAdmin: Bridge proxy admin, CrossChainERC20Factory, BridgeValidator, RelayerOrchestrator
cb-heimdall
dismissed
roger-bai-coinbase’s stale review
Approved review 4554188540 from roger-bai-coinbase is now dismissed due to new commit. Re-request for approval.
leopoldjoy
approved these changes
Jun 23, 2026
jackchuma
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Base Sepolia signing task (CHAIN-4636) that transfers control of the six Solana bridge contracts from the aliased old Coinbase L1 multisig to the aliased new Coinbase L1 multisig.
Control lives on L1, so the task is issued from the old multisig on Sepolia L1 and reaches L2 through seven
OptimismPortal2.depositTransactioncalls. Each deposit targets a contract (or the sharedERC1967Factory) directly, so the L2msg.senderis the old multisig's alias and the ownership checks pass. Routing through CBMulticall would make CBMulticall the L2 caller and revert every call, so the task extendsMultisigScript(notMultisigScriptDeposit).Owners
0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f0x6f0fB066334B67355A15dc9b67317fD2a2e208900x646132A1667ca7aD00d36616AFBA1A28116C770A0x757232A1667ca7aD00d36616AFBA1A28116C881BTransfers (7 calls)
transferOwnership+ERC1967Factory.changeAdmintransferOwnershiptransferOwnershipERC1967Factory.changeAdminERC1967Factory.changeAdminERC1967Factory.changeAdminTwo control vectors exist: the functional
owner()and the proxy upgrade admin (held in the sharedERC1967Factory). Bridge has both, so both move. The beacons are SoladyUpgradeableBeacons and govern all twins/tokens. The three proxies have noowner(), only a factory-held admin.