Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
👋 感谢贡献 CurrentMusic!@bileizhen,你好!你的拉取请求 #8 已收到(分支 本次改动:3 个文件,+89 / -1 接下来会发生什么
本仓库的合并规则
期间你可以继续向该分支推送提交,机器人会自动跟进最新改动。祝顺利合并! 🎉 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07f67b7564
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const row = out && id != null && id !== '' && [...out.querySelectorAll('.cm-song[data-song-id]')] | ||
| .find(item => item.dataset.songId === String(id)); | ||
| if (!row) { toast('当前歌曲不在此列表中'); return; } |
There was a problem hiding this comment.
Add song IDs to the profile's recent-song rows
When a user plays a song from a public profile's “最近听过” list and then long-presses the mini player, this lookup always reports that the song is absent, even though its row is displayed. web/src/pages/profile.js renders those playable .cm-song rows through its own songRow template, which only sets data-i; the new data-song-id attribute is added exclusively to the shared songListHTML renderer. Add the same song-ID annotation to the profile renderer so the new locator works for that existing playback flow.
Useful? React with 👍 / 👎.
改动
验证
npm ci和npm run build通过。node --check检查两个修改的 JS 文件通过,git diff --check通过。