Add dontSeeOrderInDatabase (order parity with subscriptions) - #78
Open
fafera wants to merge 3 commits into
Conversation
Mirrors seeOrderInDatabase / dontSeeSubscriptionInDatabase: resolves the table name and maps criteria via the order storage, then delegates to the negative WPDB assertion. Status normalization is inherited for free through mapCriteria().
…tests Docblock example used an invalid order status. The normalization tests only asserted a non-match, which passes with or without normalization; add an expectThrowable assertion (mirroring the subscription test) that actually fails if the unprefixed status stops being normalized.
SubscriptionHPOSCest had a dontSeeSubscriptionInDatabase normalization test, but SubscriptionCest (Legacy) did not. OrderCest and OrderHPOSCest now both have one; mirror it into SubscriptionCest so both entities have symmetric coverage under both storages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dontSeeOrderInDatabase(array $criteria): voidtoOrderMethods, mirroringdontSeeSubscriptionInDatabase— resolves the order table name and maps criteria viaorderStorage()->mapCriteria(), then delegates to the WPDB negative assertion.mapCriteria()'snormalizeStatusInCriteria()chokepoint; no normalization logic was added here.OrderCestandOrderHPOSCest, including a case proving the unprefixed status is actually normalized (not just a non-match).Closes #59.
Test plan
vendor/bin/codecept buildrun to regenerate the actor classOrderCestandOrderHPOSCestpass under Legacy and HPOS storage respectively