Status normalization: criteria methods (see*InDatabase, dontSee*InDatabase, grab*IdFromDatabase) - #75
Open
fafera wants to merge 1 commit into
Conversation
Normalize the status value inside criteria arrays passed to see*InDatabase, dontSee*InDatabase, and grab*IdFromDatabase, so an unprefixed status (e.g. 'active') matches rows stored with the wc- prefix. Adds a shared normalizeStatusInCriteria() step to the storage mapCriteria() chokepoint, with HPOS/Legacy storages each declaring their own status column name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see*InDatabase,dontSee*InDatabase, andgrab*IdFromDatabasenow normalize thestatus/post_statuscriterion, so an unprefixed value likeactivematches rows stored aswc-active.normalizeStatusInCriteria()toAbstractStorage, driven by each storage'sgetStatusColumnName(), and calls it from themapCriteria()chokepoint in both HPOS and Legacy storages.HPOSOrderStorageandHPOSSubscriptionStoragenow delegate toparent::mapCriteria()instead of reimplementing the mapping loop, closing the gap where a future override could silently skip normalization.Closes #21.
Test plan
composer check(PHPStan + PHPCS)OrderHPOSCest,SubscriptionHPOSCest(HPOS mode)OrderCest,SubscriptionCest(Legacy mode)CartCest/CheckoutCest