Repository navigation
Conversation
Steam Deck OLED units on current EC firmware report PDFV 0x1100 with BoardID 0x5. That combination is absent from deviceVersions, so SupportedDevice is null and both GetMaxBatteryCharge() and SetMaxBatteryCharge() return early - the Charge Limit menu is inert and silently does nothing. The register layout is unchanged from 0x1050. Verified against the device's own ACPI DSDT, which declares OperationRegion XECB at base 0xFE700B00 with field MCBL at +0x9F (phys 0xFE700B9F) - exactly the address MCBL already targets. Confirmed on hardware: with the entry added, writing 90 to MCBL starts charging within 13s at ~18.5W from 83%, and writing 80 stops it within 10s. Added alongside 0x1050 rather than replacing it, so existing devices are unaffected.
BatteryChargeLimit defines only ApplyValue and hardcodes ActiveOption = "?", so the menu never queries the live value. It shows a placeholder until the user sets a value in that session, and returns to the placeholder on every restart. This is not model-specific - no Steam Deck displays its actual charge limit today. Add a CurrentValue delegate following the same pattern as Brightness and RefreshRate, so MenuItemWithOptions.Update() populates the active option from Vlv0100.GetMaxBatteryCharge().
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Steam Deck OLED running current EC firmware, the Charge Limit menu is inert: it shows a placeholder, selecting a value does nothing, and the battery charges past the limit.
Two independent causes:
1. The device isn't in
deviceVersions. My unit reportsPDFV = 0x1100,XBID = 0x05. The table only has0x1050 / 0x5for OLED, soSupportedDeviceis null and bothGetMaxBatteryCharge()andSetMaxBatteryCharge()return early without doing anything.2.
BatteryChargeLimitnever reads the live value. It defines onlyApplyValueand hardcodesActiveOption = "?". UnlikeBrightnessandRefreshRate, it has noCurrentValuedelegate, soMenuItemWithOptions.Update()has nothing to call. This is not model-specific - as far as I can tell no Steam Deck has ever displayed its actual charge limit in this menu; it only shows a value after you set one in that session, and reverts to?on restart.Evidence that the register is unchanged
Rather than assume the offset, I read the device's own ACPI DSDT via
GetSystemFirmwareTable(no driver or elevation needed) and parsed the AML field definitions:MCBLsits at0xFE700B00 + 0x9F, exactly where the existing constant points. The layout did not move between0x1050and0x1100, so adding the version is sufficient - no address changes are needed.Hardware verification
With the entry added, writing
MCBLtakes effect immediately and reversibly. Plugged in at 83%:MCBLReported capacity rose 43,743 → 44,294 mWh while the limit was 90, and froze when it went back to 80. Before the change, the same battery charged from 16% to 87% straight through 80% without pausing.
Note the LED goes green when the cap is reached - that is "on AC, not charging", not a fault.
Changes
CommonHelpers/Vlv0100.cs- addFirmware = 0x1100, BoardID = 0x5alongside0x1050rather than replacing it, so existing devices are unaffected.PowerControl/Options/BatteryChargeLimit.cs- add aCurrentValuedelegate following the existingBrightness/RefreshRatepattern.Testing
Built from this branch and running on the device:
F7G0114, ECPDFV 0x1100/XBID 0x05net6.0-windows0xFE700B9FFanControl,PerformanceOverlay,SteamControllerall still start and run normally with the rebuiltCommonHelpersI only have an OLED unit on this firmware, so the LCD paths are unchanged-by-construction rather than tested.
🤖 Generated with Claude Code