Skip to content

fix(Mp42Hls): reject E-AC-3 sample descriptions with no usable dec3 atom #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AetherAI3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Mp42Hls): reject E-AC-3 sample descriptions with no usable dec3 atom #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Source/C++/Apps/Mp42Hls/Mp42Hls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,6 +2072,13 @@ main(int argc, char** argv)
unsigned int number_of_channels = 0;
AP4_String track_language;
AP4_Dec3Atom* dec3 = AP4_DYNAMIC_CAST(AP4_Dec3Atom, sample_description->GetDetails().GetChild(AP4_ATOM_TYPE_DEC3));
if (dec3 == NULL || dec3->GetSubStreams().ItemCount() == 0) {
// sample description says E-AC-3 but the dec3 atom is missing, wrongly
// typed, or carries no substream entries; the descriptor below reads
// dec3->GetSubStreams()[0], which would fault on either.
fprintf(stderr, "ERROR: E-AC-3 sample description is missing a usable dec3 atom\n");
goto end;
}
AP4_BitWriter bits(8);
bits.Write(0xCC, 8);
bits.Write(0x06, 8); // fixed value
Expand Down