Repository navigation
fix: use ExecOperations in release tasks for Gradle 9 - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: none
Description of Changes
Gradle 9 removed
Project.exec(), and the wrapper has been on Gradle 9 since #64. Since then every release task in the root build.gradle fails with "Could not find method exec()". This change gets anExecOperationsinstance through an injected interface once at configuration time and callsexecOps.exec { }in place ofexec { }. The commands and their spec settings are unchanged.Description of how you validated changes
With Gradle 9.4.0 from the wrapper on JDK 17,
./gradlew preRelease -PreleaseVersion=0.1.3and./gradlew listReleasesfailed with "Could not find method exec()" before the change. After it, preRelease reports the working tree status, branch and tag checks. listReleases lists local tags, checkGitStatus and getCurrentBranch behave as before, and generateChecksums (run with stub jars and-x buildAll) writes the same hashes assha256sum. I did not run the tasks that push to the remote.Checklist
healthomics-nextflow-rules/src/main/resources/rulesets/healthomics.xml./gradlew clean build)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Found with groovyfmt, a Groovy formatter and linter.