Skip to content

fix: use REGIONAL endpoint for integration test REST APIs#3933

Merged
vicheey merged 1 commit into
developfrom
fix-integ-tests-use-regional-api
May 29, 2026
Merged

fix: use REGIONAL endpoint for integration test REST APIs#3933
vicheey merged 1 commit into
developfrom
fix-integ-tests-use-regional-api

Conversation

@vicheey
Copy link
Copy Markdown
Contributor

@vicheey vicheey commented May 29, 2026

Issue #, if available

N/A

Description of changes

Switch all integration test templates that create REST APIs from the default EDGE to REGIONAL via Globals.Api.EndpointConfiguration.

This avoids hitting the stricter quota limit of edge-optimized APIs. Templates that explicitly test EDGE behavior (custom domain edge tests, security policy edge tests) are left unchanged.

Description of how you validated changes

Deployed and run test in my personal AWS Account,

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey requested a review from a team as a code owner May 29, 2026 03:43
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: 1d4cc7c..1b408a1
Files: 38
Comments: 1

Comment thread integration/resources/templates/combination/api_with_cors_and_apikey.yaml Outdated
@vicheey vicheey force-pushed the fix-integ-tests-use-regional-api branch from 1b408a1 to 4968b0e Compare May 29, 2026 03:50
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: 1d4cc7c..4968b0e
Files: 38
Comments: 1

Comment thread integration/resources/templates/combination/api_with_cors_and_apikey.yaml Outdated
Switch all integration test templates that create REST APIs from
the default EDGE to REGIONAL via Globals.Api.EndpointConfiguration.

This avoids hitting the stricter DeleteRestApi rate limit for
edge-optimized APIs (which involve CloudFront distribution teardown)
and enables faster cleanup by the sweeper function.

Templates that explicitly test EDGE behavior (custom domain edge
tests, security policy edge tests) are left unchanged.
@vicheey vicheey force-pushed the fix-integ-tests-use-regional-api branch from 4968b0e to c9d6148 Compare May 29, 2026 03:56
@vicheey vicheey merged commit e442d9f into develop May 29, 2026
9 checks passed
@vicheey vicheey deleted the fix-integ-tests-use-regional-api branch May 29, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants