Repository navigation
ci: replace CodeQL default setup with advanced setup for fork PRs - #5507
Merged
Merged
Conversation
CodeQL was configured via GitHub-managed default setup, whose analysis only runs for branches in the base repository. Since the `CodeQL` status check is required on `main`, pull requests from forks were permanently blocked: the check sat in "Expected — waiting for status to be reported" and could never be satisfied. Add a checked-in advanced-setup workflow that also runs on pull_request, so fork PRs are analyzed and can report the required `CodeQL` check. The languages (actions, javascript-typescript), default query suite, remote threat model, and weekly schedule mirror the previous default setup. Fork-PR runs remain gated behind the repository's external-contributor Actions approval policy, so a maintainer still approves before CodeQL runs against a fork's code. Closes #5506
dreamorosi
reviewed
Jul 27, 2026
dreamorosi
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeQL was configured via GitHub-managed default setup, which only analyzes branches in the base repository — so PRs from forks were permanently blocked by the required
CodeQLstatus check, which sat in "Expected — waiting for status to be reported" forever. This replaces default setup with a checked-in advanced-setup workflow that also runs onpull_request, so fork PRs are analyzed and can satisfy the required check.Changes
.github/workflows/codeql.yml(advanced setup) triggering onpushtomain,pull_requesttomain, and a weekly scheduleactionsandjavascript-typescript, default query suite, remote threat model, weekly cadenceCodeQLcheck reported by the GitHub Advanced Security app — the exact context required onmain— is still produced, so branch protection needs no changesecure-workflows.ymlgate);actionlintpassesNote: CodeQL default setup has already been disabled (repo Settings → Code security → Code scanning), because advanced and default setup can't both be active — with default setup on, the advanced workflow's SARIF upload is rejected and the required
CodeQLcheck can't pass. This PR's ownCodeQLcheck is now green, produced by this workflow. Until this PR merges,mainitself has no CodeQL scanning (the workflow only takes effect onmainonce merged), so merging promptly closes that gap.Issue number: closes #5506
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.