Allow Annotations on ServiceAccounts and Conditional Creation#78
Open
hflobao wants to merge 1 commit into
Open
Allow Annotations on ServiceAccounts and Conditional Creation#78hflobao wants to merge 1 commit into
hflobao wants to merge 1 commit into
Conversation
|
Confirmed that this fix is working. Could this be reviewed and merged? We do not want to maintain custom charts. |
sky333999
reviewed
Nov 13, 2025
| issuerAnnotations: { } | ||
| serviceAccount: | ||
| name: # override agent service account name | ||
| annotations: { } # optional annotations for the service account |
Contributor
There was a problem hiding this comment.
Would you mind adding these for dcgmExporter and neuronMonitor as well to keep them consistent? And accordingly update their templates to use them.
|
Hi @hflobao, just checking in on this PR. It would really help our team - we're currently blocked on IRSA integration for the CloudWatch agent. If you don't have bandwidth to address the review comments, I'm happy to fork your branch and complete the remaining changes for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
For the operator ServiceAccount, the configuration for 'create' and 'annotations' were present in the values file, but not evaluated in the template.
For the agent ServiceAccount, added the 'annotations' configuration in both the template and the values file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.