Update config values#269
Open
sparrc wants to merge 1 commit into
Open
Conversation
c4ffaa2 to
0229998
Compare
|
We are seeing regular OOM kills on our fluent-bit pods and I found this PR while researching after AI basically recommended a similar set of changes. It feels off putting to need to modify this on my end if the underlying isnt configured appropriately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
I have made a selection of changes to the default config for the following reasons.
Overall the changes are meant to limit runaway memory usage on the fluent-bit container, by setting mem_buf_limit on all input plugins.
One other thing to consider would be to add two new config parameters:
workersfor the output plugins andthreadedfor the input plugins, which enables multi-threading on the fluent-bit process to increase efficiency and free up fluent-bit's main thread. These options, however, require that the user is using aws-for-fluent-bit version 3+. Is this an assumption we can safely make?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.