Skip to content

fix: name the clock in the time-window skip row - #858

Merged
av1155 merged 4 commits into
mainfrom
fix/time-window-utc-label
Nov 9, 2026
Merged

av1155 merged 4 commits into
mainfrom
fix/time-window-utc-label

Conversation

@av1155

@av1155 av1155 commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

When TZ names a zone the container can't load, the C library runs on UTC, but the Allowed Search Window skip row still said "Local time", so the Logs page showed a plausible wrong hour. The row now names the clock it really used.

Closes #824

Changes

  • When TZ couldn't be loaded, the skip reason reads outside allowed time window (TZ=<value> not loaded, using UTC), using the same check as the startup warning. The Logs page shows the reason, not the message, so that's where the value has to appear.
  • The message, which the container log and /api/logs carry, starts with UTC time in that case instead of Local time. An unset TZ, UTC and zones that load keep the current text.
  • skip-reasons.md and environment-variables.md describe the new reason, and the CHANGELOG gets a Fixed bullet.

Testing

All checks pass. New tests cover the reason and message for a zone that can't load, the unchanged text for loadable zones, and the rendered Logs page row.

Type of Change

  • Bug fix (fix:)
  • New feature (feat:)
  • Refactoring (refactor:)
  • Documentation (docs:)
  • CI/CD (ci:)
  • Chore (chore:)

Checklist

  • Issue exists and is linked above with Closes #N
  • Linked issue has exactly one type:* and one priority:* label
  • Linked issue has at most one phase:* label (or none when not roadmap work)
  • Branch name matches issue scope (feat/<slug>, fix/<slug>, etc.)
  • Tests added/updated for all changes
  • Type check passes (mypy src/)
  • Lint passes (ruff check .)
  • Format passes (ruff format --check .)
  • Documentation updated (if applicable)
  • No secrets or sensitive data committed
  • Scope check: This change helps search for missing or cutoff-unmet media in a controlled way

When TZ names a zone the container cannot load, the C library runs on
UTC, but the skip row still said "Local time", so the Logs page showed
a plausible wrong hour. The row now says "UTC time" and names the TZ
value in that case, using the same check as the startup warning.

Closes #824
The Logs page renders a row's reason, and falls back to the message
only when there is no reason. The window gate always sets one, so the
previous commit's message text never reached the page. Carry the
signal in the reason instead, keep the clock in the message for the
container log and /api/logs, and test the rendered page.
@av1155
av1155 merged commit b66a8db into main Nov 9, 2026
37 checks passed
@av1155
av1155 deleted the fix/time-window-utc-label branch November 9, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: the time-window skip row calls UTC "Local time"

1 participant