Repository navigation
fix: name the clock in the time-window skip row - #858
Merged
Merged
Conversation
When TZ names a zone the container cannot load, the C library runs on UTC, but the skip row still said "Local time", so the Logs page showed a plausible wrong hour. The row now says "UTC time" and names the TZ value in that case, using the same check as the startup warning. Closes #824
The Logs page renders a row's reason, and falls back to the message only when there is no reason. The window gate always sets one, so the previous commit's message text never reached the page. Carry the signal in the reason instead, keep the clock in the message for the container log and /api/logs, and test the rendered page.
…abel # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
TZnames a zone the container can't load, the C library runs on UTC, but the Allowed Search Window skip row still said "Local time", so the Logs page showed a plausible wrong hour. The row now names the clock it really used.Closes #824
Changes
TZcouldn't be loaded, the skip reason readsoutside allowed time window (TZ=<value> not loaded, using UTC), using the same check as the startup warning. The Logs page shows the reason, not the message, so that's where the value has to appear./api/logscarry, starts withUTC timein that case instead ofLocal time. An unsetTZ,UTCand zones that load keep the current text.skip-reasons.mdandenvironment-variables.mddescribe the new reason, and the CHANGELOG gets a Fixed bullet.Testing
All checks pass. New tests cover the reason and message for a zone that can't load, the unchanged text for loadable zones, and the rendered Logs page row.
Type of Change
fix:)feat:)refactor:)docs:)ci:)chore:)Checklist
Closes #Ntype:*and onepriority:*labelphase:*label (or none when not roadmap work)feat/<slug>,fix/<slug>, etc.)mypy src/)ruff check .)ruff format --check .)