Repository navigation
Conversation
The generated signup_login flow gives the passkey option a login_flow only, since an account cannot be created with a passkey, but the schema required signup_flow on every option except select_account. Saving the generated flow as a custom flow therefore failed validation. The runtime never reads signup_flow for passkey. ref DEV-3921
Add App.generatedAuthenticationFlows, the flow of each type that Authgear generates from the app's settings, in the shape of the authentication_flow config section. The flow builder uses it to start a custom flow from the current settings. ref DEV-3921
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEV-3921
The upcoming flow builder needs the flows Authgear generates from a project's settings, so "Start from my current settings" can turn them into an editable custom flow. Reading and saving flows otherwise uses the existing
updateApppath.Changes
App.generatedAuthenticationFlows: AuthenticationFlowConfig!(portal GraphQL)defaultper type: signup, promote, login, signup_login, reauth, account recovery.authentication_flowsection ofauthgear.yaml.Passkey in
signup_loginno longer requiressignup_flowThe generator gives the passkey option a
login_flowonly, since an account cannot be created with a passkey. The schema requiredsignup_flowon every option exceptselect_account, so a passkey project's generated flow failed validation when saved as a custom flow. The runtime only readssignup_flowfor login ID, OAuth, and LDAP options. This accepts more config than before, so it is not breaking.Known gap
A project without an email or phone login ID gets an account recovery flow with no options. It is returned as generated; saved as a custom flow it fails validation. The builder will flag it (DEV-3935).
Tests
generate_config_test.go: for four settings combinations (defaults; phone + SMS OTP; username + password + required 2FA; email + passkey + Google), the generated flows saved back as custom flows passconfig.Parse. The username case asserts the account recovery error above.signup_login_flow_tests.yaml: passkey withoutsignup_flow(valid), with both (valid), withoutlogin_flow(invalid).