Repository navigation
Fix React Native imports with a read-only window global - #744
Merged
Merged
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change removes the read-only assignment failure with no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes React Native imports when the window global is read-only.
Changes:
- Reads the existing global without assigning to it.
- Retains webpack exports and the
HomeyLibfallback.
| File | Description |
|---|---|
| react-native/index.js | Replaces the global assignment with a local reference used by the fallback export. |
Review effort: Balanced
RobinBol
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windowglobal is read-only.window.HomeyLibfallback.