Repository navigation
Updated flowcard schema to only allow 'title' and 'label' for dropdown argument values - #738
Open
wouter-athom wants to merge 1 commit into
Open
wouter-athom wants to merge 1 commit into
wouter-athom wants to merge 1 commit into
Conversation
…n values Dropdown argument values didn't get checked for valid properties. This made it so you could have dropdown argument titles resulting in `null`. Fixed by requiring either `title` (the modern vairant) or `label` (legacy).
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Reject undeclared dropdown properties and regenerate the TypeScript declaration.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates flow-card manifest validation so dropdown values require a title or legacy label.
Changes:
- Adds dropdown
labelsupport and title/label requirements. - Adds validation tests for dropdown and multiselect values.
| File | Summary |
|---|---|
test/validate-flow-card-manifest.js |
Adds schema validation coverage. |
assets/app/schema.json |
Updates dropdown validation; undeclared properties remain permitted, and the generated TypeScript declaration is out of sync. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
550
to
+559
| "title": { | ||
| "$ref": "#/definitions/i18nObject" | ||
| }, | ||
| "label": { | ||
| "$ref": "#/definitions/i18nObject" | ||
| } | ||
| } | ||
| }, | ||
| "anyOf": [ | ||
| { "required": ["title"] }, | ||
| { "required": ["label"] } |
jeroenwienk
approved these changes
Sep 24, 2026
Contributor
|
BTW we should not every promote this deprecated label property. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdown argument values didn't get checked for valid properties. This made it so you could have dropdown argument titles resulting in
null.Fixed by requiring either
title(the modern vairant) orlabel(legacy).