Repository navigation
Fix support for src/ layout even without setup.py - #161
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 80.21% 76.61% -3.60%
==========================================
Files 4 4
Lines 379 402 +23
==========================================
+ Hits 304 308 +4
- Misses 75 94 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
astrofrog
force-pushed
the
src-layout-hook
branch
from
September 15, 2026 10:18
908d88d to
bb72376
Compare
astrofrog
marked this pull request as ready for review
September 15, 2026 10:57
Cadair
approved these changes
Sep 15, 2026
| [options] | ||
| packages = find: | ||
| package_dir = | ||
| = {'src' if src_layout else '.'} |
Member
Author
There was a problem hiding this comment.
Oops not sure what happened there but indeed very weird that this works
Member
Author
There was a problem hiding this comment.
No wait sorry it's fine it's standard recommendation for src/ layout, see e.g. https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#using-a-src-layout
Member
Author
There was a problem hiding this comment.
# This example contains just the necessary options for a src-layout, set up
# the rest of the file as described above.
[options]
package_dir=
=src
packages=find:
[options.packages.find]
where=src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of #157 and should be rebased once that PR is merged