Repository navigation
Use SABIModule in non-CUDA CMake build of extension module - #414
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
From manually downloading and extracting the built |
|
Merging this without review as this is only changing build config and build appears to be succeeding and I have confirmed after installing from a CI built wheel locally, I can successfully (outside of |
Should resolve #413
Request the
Development.SABIModulecomponent for non-CUDA branch of CMake build for extension module so that the built extension is a stable ABI build not a version specific one, consistent with thescitkit-buildconfiguration inpyproject.tomlwhich is what dictates the tags applied to the wheels. This was already happening for the CUDA branch but hadn't been propagated to non-CUDA branch.We will need to make a new release after this is merged to have fixed wheel on PyPI.