Skip to content

Use SABIModule in non-CUDA CMake build of extension module - #414

Merged
matt-graham merged 1 commit into
mainfrom
mmg/s2fft-lib-import-error-fix
Oct 9, 2026
Merged

matt-graham merged 1 commit into
mainfrom
mmg/s2fft-lib-import-error-fix

Conversation

@matt-graham

Copy link
Copy Markdown
Collaborator

Should resolve #413

Request the Development.SABIModule component for non-CUDA branch of CMake build for extension module so that the built extension is a stable ABI build not a version specific one, consistent with the scitkit-build configuration in pyproject.toml which is what dictates the tags applied to the wheels. This was already happening for the CUDA branch but hadn't been propagated to non-CUDA branch.

We will need to make a new release after this is merged to have fixed wheel on PyPI.

@matt-graham matt-graham added the bug Something isn't working label Oct 9, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@matt-graham

Copy link
Copy Markdown
Collaborator Author

From manually downloading and extracting the built macos-latest wheels produces as an artifact on the CI build these do now appear to be creating correctly suffixed _s2fft.abi3.so extension modules

@matt-graham

Copy link
Copy Markdown
Collaborator Author

Merging this without review as this is only changing build config and build appears to be succeeding and I have confirmed after installing from a CI built wheel locally, I can successfully (outside of s2fft repository root...) run both import s2fft and from s2fft_lib import _s2fft.

@matt-graham
matt-graham merged commit 895b8aa into main Oct 9, 2026
8 checks passed
@matt-graham
matt-graham deleted the mmg/s2fft-lib-import-error-fix branch October 9, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot import s2fft on Python 3.13 or 3.14

1 participant