chore: remove unused dependencies#294
Merged
Merged
Conversation
Resolves open security alert — apscheduler was a leftover from a previous version and is not used anywhere in the codebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove four runtime deps with zero usages in src/: - python-dateutil (codebase uses stdlib datetime) - requests (codebase uses httpx) - aiofiles - sqlalchemy[mypy] (chat module was removed, dep was left behind) Also remove their corresponding dev type stubs (types-requests, types-python-dateutil, types-aiofiles) and clean up stale mypy.ini sections and the sqlalchemy.ext.mypy.plugin entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
philipph-askui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused runtime dependencies and cleans up related config leftovers. All removals were verified via static import search (no
importorfromreferences anywhere insrc/) and confirmed against the lock file.Runtime deps removed:
apscheduler==4.0.0a6— leftover from a previous version; resolves the open Dependabot security alertrequests— codebase useshttpxthroughout; still installed transitively viasegment-analytics-pythonetc.python-dateutil— stdlibdatetimeused everywhere; still installed transitively viagoogle-authetc.aiofiles— no usages; fully removed from the lock filesqlalchemy[mypy]— leftover from the removed chat module; fully removed from the lock fileDev type stubs removed (no longer needed without the runtime deps):
types-requests,types-python-dateutil,types-aiofilesmypy.inicleaned up:sqlalchemy.ext.mypy.pluginfrom thepluginsline[mypy-*]sections tied to the removed chat module (alembic,structlog,starlette_context,asgi_correlation_id,prometheus_fastapi_instrumentator,mss,opentelemetry.instrumentation.sqlalchemy)Test plan
src/andtests/importlib.import_module,__import__,try/exceptoptional imports) referencing removed packagespdm run typecheck:allpasses cleanly (337 files, no issues)🤖 Generated with Claude Code